[REMI] Fix deprecated return signature in PPT reconstruction
Description
PPT reconstruction is an optional feature in the REMI notebook to support older data from 2021 and earlier, where the timeserver was not saved reliably. It simulates a PPT based on some edge signal (e.g. a diode) indicating presence of pulses, so that the main production code can continue assuming presence of a timeserver.
The timeserver was forgotten by accident when taking laser-only data some days ago, so I noticed some minor deprecation bugs when enabling it agian. Also, I added support for reconstructing PPL pulses in the case of ignore_fel and not ignore_ppl.
This was hotfixed directly on live for the sake of operations.
How Has This Been Tested?
run = 10
in_folder = '/gpfs/exfel/exp/SQS/202501/p007901/raw'
calib_config_path = '/gpfs/exfel/exp/SQS/202501/p007901/usr/remi_proc_config.yaml'
ignore_fel = True
reconstruct_ppt = True
trigger_edge_channel = '2_D'
trigger_edge_offset = -250Types of changes
- Bug fix (non-breaking change which fixes an issue)
- New feature (non-breaking change which adds functionality)
Reviewers
@kluyvert (feel free to ignore)