Skip to content

[Hotfix] Distinguish failed injections from partial duplicates

Philipp Schmidt requested to merge fix/duplicate_injection_no_error into master

Description

Apologies for the late MR, this change has been hotfixed already for the past two weeks and is only here for documentation purposes.

The complex CalibrationClient.inject_new_calibration_constant_version() used to inject constants in this first attempt may raise an error even if the actual injection was successful, if some of its sub-components (report, condition, cc, pdu?) already exist. These are actually done in separate API calls inside this method. As with most other CalCat interactions, we should move to performing this call ourselves to better handle different edge cases.

For now, this MR tries to decipher the returned error information and decide whether it actually is one.

How Has This Been Tested?

Injecting darks in production 🤷

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code follows the code style of this project.

Reviewers

@ahmedk @kluyvert @manettim

Merge request reports

Loading